chore: migrate expect and @jest/expect type tests to TSTyche
#14910
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
| expect(jestExpect(null)).type.toHaveProperty('toMatchSnapshot'); | ||
|
|
||
| expect(_expect(null)).type.not.toHaveProperty('toMatchSnapshot'); |
There was a problem hiding this comment.
TSTyche can check if property exists. That’s way better than just expectError.
| test('is superset of `Expect`', () => { | ||
| expect<typeof jestExpect>().type.toMatch<typeof _expect>(); | ||
|
|
||
| expect<typeof _expect>().type.not.toMatch<typeof jestExpect>(); |
There was a problem hiding this comment.
Fun to play with .toMatch(). That’s another novelty and it does the right job here.
| }); | ||
|
|
||
| test('does not define the `.toMatchSnapshot()` matcher', () => { | ||
| expect(_expect(null)).type.not.toHaveProperty('toMatchSnapshot'); |
There was a problem hiding this comment.
jestExpect would not look right here, or? This is expectExpect, but expect(expectExpect is somewhat too much.
|
@SimenB Did I address all your comments? Or did I miss something? No rush, if you are busy. This can wait. Just checking if some more changes are expected or not. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR migrates
expectand@jest/expecttype tests to TSTyche. The diff is noisy, but the tests look much better.Test plan
Type test must pass in CI.